chore(pipeline): timetable adjustments under pipelining#21076
Open
Maddiaa0 wants to merge 1 commit intographite-base/21076from
Open
chore(pipeline): timetable adjustments under pipelining#21076Maddiaa0 wants to merge 1 commit intographite-base/21076from
Maddiaa0 wants to merge 1 commit intographite-base/21076from
Conversation
Maddiaa0
changed the title
Maddiaa0
changed the title
Maddiaa0
force-pushed
the
md/pipeline-timetable
branch
from
6f951d7 to
5871d42
Compare
Maddiaa0
force-pushed
the
md/pipelining-syncing
branch
from
8de6157 to
31f941d
Compare
This was referenced Mar 3, 2026
Member
Author
Maddiaa0
force-pushed
the
md/pipeline-timetable
branch
from
5871d42 to
990033f
Compare
Maddiaa0
force-pushed
the
md/pipelining-syncing
branch
4 times, most recently
from
27f8a4b to
f5c6308
Compare
Maddiaa0
force-pushed
the
md/pipeline-timetable
branch
from
990033f to
92ac108
Compare
Maddiaa0
force-pushed
the
md/pipelining-syncing
branch
from
f5c6308 to
ae6b651
Compare
Maddiaa0
force-pushed
the
md/pipeline-timetable
branch
from
92ac108 to
2a965f2
Compare
Maddiaa0
force-pushed
the
md/pipeline-timetable
branch
from
2a965f2 to
c2df8a2
Compare
Maddiaa0
force-pushed
the
md/pipelining-syncing
branch
from
ae6b651 to
3a47fbf
Compare
Maddiaa0
force-pushed
the
md/pipeline-timetable
branch
from
c2df8a2 to
6ccc88b
Compare
Maddiaa0
force-pushed
the
md/pipelining-syncing
branch
from
3a47fbf to
4bb6845
Compare
Maddiaa0
force-pushed
the
md/pipeline-timetable
branch
from
6ccc88b to
d349239
Compare
Maddiaa0
force-pushed
the
md/pipelining-syncing
branch
from
4bb6845 to
0e9b52e
Compare
Maddiaa0
force-pushed
the
md/pipelining-syncing
branch
from
0e9b52e to
dee426a
Compare
Maddiaa0
force-pushed
the
md/pipeline-timetable
branch
from
d349239 to
24f6555
Compare
Maddiaa0
force-pushed
the
md/pipeline-timetable
branch
from
24f6555 to
cb21eb9
Compare
Maddiaa0
force-pushed
the
md/pipelining-syncing
branch
from
dee426a to
5820d21
Compare
Maddiaa0
changed the base branch from
md/pipelining-syncing
to
graphite-base/21076
Maddiaa0
force-pushed
the
graphite-base/21076
branch
from
5820d21 to
eedf075
Compare
Maddiaa0
force-pushed
the
md/pipeline-timetable
branch
from
cb21eb9 to
45ff14f
Compare
Maddiaa0
force-pushed
the
graphite-base/21076
branch
from
eedf075 to
7c2c34a
Compare
Maddiaa0
force-pushed
the
md/pipeline-timetable
branch
from
45ff14f to
456e3e9
Compare
Maddiaa0
force-pushed
the
graphite-base/21076
branch
from
7c2c34a to
c2cc23c
Compare
Maddiaa0
force-pushed
the
md/pipeline-timetable
branch
from
456e3e9 to
f9ca5bf
Compare
Maddiaa0
changed the base branch from
graphite-base/21076
to
md/pipelining-syncing
Maddiaa0
changed the base branch from
md/pipelining-syncing
to
graphite-base/21076
Maddiaa0
force-pushed
the
md/pipeline-timetable
branch
from
f9ca5bf to
e50ad91
Compare
Maddiaa0
force-pushed
the
graphite-base/21076
branch
from
c2cc23c to
2d31671
Compare
Maddiaa0
changed the base branch from
graphite-base/21076
to
md/pipelining-syncing
Maddiaa0
force-pushed
the
md/pipeline-timetable
branch
from
e50ad91 to
890ce40
Compare
Maddiaa0
force-pushed
the
md/pipelining-syncing
branch
from
2d31671 to
2591475
Compare
Maddiaa0
force-pushed
the
md/pipeline-timetable
branch
from
890ce40 to
ce7da45
Compare
Maddiaa0
changed the base branch from
md/pipelining-syncing
to
graphite-base/21076
spalladino
approved these changes
Mar 31, 2026
Contributor
spalladino
left a comment
spalladino
left a comment
There was a problem hiding this comment.
Looks good! There seems to be a few changes still pending from the proposal handler, but nothing that can't addressed in a later PR.
Also, let's update the timetable (or a new sequencer one?) README, to clarify that when pipelining is enabled, building and block reexecution happens during slot N-1, while checkpoint proposal, attestation gathering, and L1 submission happens during N.
| /** Returns epoch/slot info for the next L1 slot with pipeline offset applied. */ | ||
| getTargetEpochAndSlotInNextL1Slot(): EpochAndSlot & { nowSeconds: bigint }; | ||
| isProposerPipeliningEnabled(): boolean; | ||
| pipeliningOffset(): number; |
Contributor
There was a problem hiding this comment.
Nit: in another PR (so as not to have to update the entire stack), it'd be good to rename to pipelineOffsetInSlots or pipelineSlotOffset. I originally thought it was number of seconds.
Comment on lines
+466
to
+468
| // If we are pipelining and have a pending checkpoint number stored, we will allow the block proposal to be for a slot further | ||
| const syncedSlot = await this.blockSource.getSyncedL2SlotNumber(); | ||
| if (syncedSlot !== undefined && syncedSlot + 1 >= slot) { | ||
| if (syncedSlot !== undefined && syncedSlot + 1 + this.epochCache.pipeliningOffset() >= slot) { |
Contributor
There was a problem hiding this comment.
Heads up that in L254 you don't call this function if pipelining is disabled
Comment on lines
452
to
455
| private getReexecutionDeadline(slot: SlotNumber, config: { l1GenesisTime: bigint; slotDuration: number }): Date { | ||
| const nextSlotTimestampSeconds = Number(getTimestampForSlot(SlotNumber(slot + 1), config)); | ||
| return new Date(nextSlotTimestampSeconds * 1000); | ||
| } |
Contributor
There was a problem hiding this comment.
Should we adjust this deadline for pipelining?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
When pipelining, don't leave checkpoint submission to determine when the timeslot ends - as we have the entire of the next slot for that